Re: [PATCH] arm64: mm: fix max_mapnr is assigned the wrong value

From: Catalin Marinas
Date: Mon Apr 01 2019 - 10:32:48 EST


On Mon, Apr 01, 2019 at 10:21:58PM +0800, Muchun Song wrote:
> Thanks for your reply. In fact, I didn't hit any problem. I just read the code
> and found the problem. I see max_mapnr is to only be used in the
> generic pfn_valid().
> As you said, we do not use it on arm64. So in a sense, the patch is
> meaningless.
>
> But I think since it is a problem, why not fix it (Even if max_mapnr
> is not be used)?
> What is your opinion?

I'm ok with fixing, only that it's not urgent. Will can pick it up for
the 5.2 merging window.

Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>