Re: [RFC PATCH 5/5] leds: multicolor: Introduce a multicolor class definition

From: Randy Dunlap
Date: Mon Apr 01 2019 - 17:10:40 EST


Hi,

On 4/1/19 10:34 AM, Dan Murphy wrote:
> Introduce a multicolor class that groups colored LEDs
> within a LED node.
>
> The framework allows for dynamically setting individual LEDs
> or setting brightness levels of LEDs and updating them virtually
> simultaneously.
>
> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> ---
> drivers/leds/Kconfig | 10 +
> drivers/leds/Makefile | 1 +
> drivers/leds/led-class-multicolor.c | 411 +++++++++++++++++++++++++++
> include/linux/led-class-multicolor.h | 69 +++++
> 4 files changed, 491 insertions(+)
> create mode 100644 drivers/leds/led-class-multicolor.c
> create mode 100644 include/linux/led-class-multicolor.h
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index a72f97fca57b..477e108fd2a7 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -29,6 +29,16 @@ config LEDS_CLASS_FLASH
> for the flash related features of a LED device. It can be built
> as a module.
>
> +config LEDS_CLASS_MULTI_COLOR
> + tristate "LED Mulit Color LED Class Support"

Multi

> + depends on LEDS_CLASS
> + help
> + This option enables the flash led sysfs class in /sys/class/leds.

LED (?)

> + It wrapps LED Class and adds flash LEDs specific sysfs attributes

wraps

> + and kernel internal API to it. You'll need this to provide support
> + for the flash related features of a LED device. It can be built

of an LED device.

> + as a module.
> +
> config LEDS_BRIGHTNESS_HW_CHANGED
> bool "LED Class brightness_hw_changed attribute support"
> depends on LEDS_CLASS


ciao.
--
~Randy