Re: [PATCH] Documentation: soundwire: Ensure that code is inside the code blocks

[Jonathan NeuschÃfer]

On Mon, Apr 01, 2019 at 03:40:03PM -0600, Jonathan Corbet wrote:
> On Mon,  1 Apr 2019 00:34:22 +0200
> Jonathan NeuschÃfer <j.neuschaefer@xxxxxxx> wrote:
> 
> > The way the document is written now, Sphinx renders empty code blocks
> > followed by the lines that should be inside them.
> > 
> > Unindent the code-block directives to fix this.
> > 
> > Fixes: 502c00d9c315 ("Documentation: soundwire: fix stream.rst markup warnings")
> > Signed-off-by: Jonathan NeuschÃfer <j.neuschaefer@xxxxxxx>
> 
> That definitely makes things better.  Applied, thanks.
> 
> I'm going to take out the Fixes tag, though, since the named commit did
> not, in fact, introduce that problem.

Ah, true, the wrong indentation didn't come from that commit.

> It's also good to copy authors of patches named in Fixes tags so they
> can defend themselves :)

Good idea, I'll try to remember that.


Jonathan NeuschÃfer

Attachment: signature.asc
Description: PGP signature