Re: [net-next] tg3: allow ethtool -p to work for NICs in down state

[Michael Chan]

On Mon, Apr 1, 2019 at 10:09 PM Jon Maxwell <jmaxwell37@xxxxxxxxx> wrote:
>
> Make tg3 behave like other drivers and let "ethtool -p" identify the
> NIC even when it's in the DOWN state. Before this patch it would get an
> error as follows if the NIC was down:
>
> # ip link set down dev em4
> # ethtool -p em4
> Cannot identify NIC: Resource temporarily unavailable
>
> With this patch ethtool identify works regardless of whether the NIC is up
> or down as it does for other drivers.
>
> Signed-off-by: Jon Maxwell <jmaxwell37@xxxxxxxxx>

Acked-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

We used to power down the chip in tg3_close() and that's why we cannot
do ethtool -p after close.  We don't do that any more so this is fine.
Thanks.