Re: [PATCH] watchdog: Convert to use devm_platform_ioremap_resource

From: Joel Stanley
Date: Tue Apr 02 2019 - 20:23:09 EST


On Tue, 2 Apr 2019 at 19:02, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> Use devm_platform_ioremap_resource to reduce source code size,

This is a strange name for a function that doesn't take nor return a
'struct resource'.

However, the intent is welcome as many drivers do redundant checking
of the platform_get_resource result before passing to
devm_ioremap_resource.

> improve readability, and reduce the likelyhood of bugs.

> drivers/watchdog/aspeed_wdt.c | 4 +---

Acked-by: Joel Stanley <joel@xxxxxxxxx>

Cheers,

Joel