Re: [PATCH] Revert "tty: fix NULL pointer issue when tty_port ops is not set"

[Greg Kroah-Hartman]

On Wed, Apr 03, 2019 at 09:40:53AM +0200, Johan Hovold wrote:
> This reverts commit f4e68d58cf2b20a581759bbc7228052534652673.
> 
> TTY drivers using the tty-port abstraction all provide a pointer to a
> set of port operations, which specifically cannot be NULL (or we'd find
> out at first attempt to open a port).
> 
> Revert the recent commit which added unnecessary NULL-checks and whose
> commit message indicated that it was fixing a real problem, which it did
> not.
> 
> Note that even the two tty drivers for virtual devices currently
> providing an empty set of operations probably should be implementing at
> least some of the callbacks.

This was a "future fix" for a driver that is under review for 5.2, see
the email thread:
	Subject: [PATCH 0/2] TTY: add rpmsg tty driver

It didn't want/need the port pointer, if that is incorrect, that's fine,
I'll gladly revert this, but as-is this patch isn't hurting anything,
right?

thanks,

greg k-h