Re: [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel

[Thierry Reding]

On Mon, Apr 01, 2019 at 12:35:32PM +0200, Guido GÃnther wrote:
> v4 fixes up the DT binding example and uses a wider cc list since I
> failed to extend that when touching more files.
> 
> The panel is a 5.5" 720x1440 TFT LCD MIPI DSI panel with built in
> touchscreen and backlight as found in the Librem 5 devkit.
> 
> These patches are against linux next as of 2019-03-22. v3 got acked by Sam
> Ravnborg:
> 
>   https://lists.freedesktop.org/archives/dri-devel/2019-March/209326.html
> 
> Changes from v4
> * As per review comments from Fabio Estevam
>   * Add missing unit name in dt binding docs
> 
> Changes from v3
> * Forward to next-20190322
> * Add MAINTAINERS entry
> 
> Changes from v2
> * As per review comments from Sam Ravnborg
>   * Lowercase sentinel
>   * Drop '_panel' postfix
>   * DRM_DEV_ logging instead of plain DRM_
> * Add Reviewed-by:
> * Add "panel-rocktech-" to the driver name following
>   the pattern from other drm panel drivers.
> 
> Changes from v1
> * As per review comments from Sam Ravnborg
>   * Make SPDX-License-Identifier match MODULE_LICENSE
>   * Sort include files alphabetically
>   * Drop drmP.h and use individual includes
>   * Drop superfuous 'x' in mode printout on error path
>   * Allpixelson_set: Add proper space around '*'
>   * Drop superfluous put_device(&ctx->backlight->dev);
>   * Add /* Sentinel */ in jh057n_of_match
>   * Drop jh057n->enabled
>   * Drop drm_display_info_set_bus_formats
> * Kconfig: Depend on BACKLIGHT_CLASS_DEVICE which somehow got lost
> * Move jh057n_enable close to jh057n_disable
> 
> Guido GÃnther (3):
>   dt-bindings: Add vendor prefix for ROCKTECH DISPLAYS LIMITED
>   dt-bindings: Add Rocktech jh057n00900 panel bindings
>   drm/panel: Add Rocktech jh057n00900 panel driver
> 
>  .../display/panel/rocktech,jh057n00900.txt    |  18 +
>  .../devicetree/bindings/vendor-prefixes.txt   |   1 +
>  MAINTAINERS                                   |   6 +
>  drivers/gpu/drm/panel/Kconfig                 |  13 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  .../drm/panel/panel-rocktech-jh057n00900.c    | 386 ++++++++++++++++++
>  6 files changed, 425 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt
>  create mode 100644 drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c

Applied, thanks.

checkpatch does complain about the dsi_generic_write_seq() macro
definition, because it uses flow control statements, but there are
already similar macros in other drivers, so I let this slide. We may
want to eventually come up with something better and then replace these
macros for the other drivers as well.

Thierry

Attachment: signature.asc
Description: PGP signature