Re: [PATCH v2 2/2] drm/vc4: Disable V3D interactions if the v3d component didn't probe.

From: Eric Anholt
Date: Wed Apr 03 2019 - 15:15:34 EST


Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx> writes:

> Hi,
>
> On Mon, 2019-04-01 at 11:35 -0700, Eric Anholt wrote:
>> One might want to use the VC4 display stack without using Mesa.
>> Similar to the debugfs fixes for not having all of the possible
>> display bits enabled, make sure you can't oops in vc4 if v3d isn't
>> enabled.
>
> Just thought about this: perhaps we should be returning -ENODEV instead
> of -EINVAL when !vc4->v3d, just so that the error is a bit more
> explicit to userspace?

I like it. Doing that while applying the series.

Attachment: signature.asc
Description: PGP signature