RE: [PATCH] platform/x86: dell-laptop: fix rfkill functionality

From: Mario.Limonciello
Date: Wed Apr 03 2019 - 17:54:34 EST


> -----Original Message-----
> From: Darren Hart <dvhart@xxxxxxxxxxxxx>
> Sent: Wednesday, April 3, 2019 3:24 PM
> To: Limonciello, Mario
> Cc: Andy Shevchenko; LKML; platform-driver-x86@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality
>
>
> [EXTERNAL EMAIL]
>
> On Wed, Mar 27, 2019 at 09:25:34AM -0500, Mario Limonciello wrote:
> > When converting the driver two arguments were transposed leading
> > to rfkill not working.
> >
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427
> > Reported-by: Pepijn de Vos <pepijndevos@xxxxxxxxx>
> > Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
> > Acked-by: Pali Rohár <pali.rohar@xxxxxxxxx>
>
> Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's
> been broken that long :-(
>

Not many "newer" platforms actually use this radio control anymore. It's been
superseded by other technologies. So I think that would be the main reason.

Can you CC it to stable when it's committed or do I need to re-send or anything?