Re: [PATCH 4/6 v3] csky: Fix syscall_get_arguments() and syscall_set_arguments()

[Dmitry V. Levin]

On Mon, Apr 01, 2019 at 09:41:08AM -0400, Steven Rostedt wrote:
> From: "Dmitry V. Levin" <ldv@xxxxxxxxxxxx>
> 
> C-SKY syscall arguments are located in orig_a0,a1,a2,a3,regs[0],regs[1]
> fields of struct pt_regs.
> 
> Due to an off-by-one bug and a bug in pointer arithmetic
> syscall_get_arguments() was reading orig_a0,regs[1..5] fields instead.
> Likewise, syscall_set_arguments() was writing orig_a0,regs[1..5] fields
> instead.
> 
> Link: http://lkml.kernel.org/r/20190329171230.GB32456@xxxxxxxxxxxx
> 
> Fixes: 4859bfca11c7d ("csky: System Call")
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> Cc: Will Drewry <wad@xxxxxxxxxxxx>
> Cc: Guo Ren <guoren@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v4.20+
> Signed-off-by: Dmitry V. Levin <ldv@xxxxxxxxxxxx>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

According to
https://lore.kernel.org/lkml/20190330004949.GA15705@guoren-Inspiron-7460/
the following tags could be added to this patch:

Tested-by: Guo Ren <ren_guo@xxxxxxxxx>
Acked-by: Guo Ren <ren_guo@xxxxxxxxx>


-- 
ldv

Attachment: signature.asc
Description: PGP signature