Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses

[Lawrence Brakmo]

+/v8-On 4/4/19, 10:53 AM, +ACI-David Miller+ACI- +ADw-davem+AEA-davemloft.net+AD4- wrote:

    From: +ACI-Tilmans, Olivier (Nokia - BE/Antwerp)+ACI- +ADw-olivier.tilmans+AEA-nokia-bell-labs.com+AD4-
    Date: Thu, 4 Apr 2019 12:24:02 +-0000
    
    +AD4- RFC8257 +AKc-3.5 explicitly states that +ACI-A DCTCP sender MUST react to
    +AD4- loss episodes in the same way as conventional TCP+ACI-.
    ...
    +AD4- This patch replace the clamping of alpha by setting ssthresh to
    +AD4- half of cwnd for both fast retransmissions and RTOs, at most once
    +AD4- per RTT. Consequently, the dctcp+AF8-clamp+AF8-alpha+AF8-on+AF8-loss module parameter
    +AD4- has been removed.
    
    Applied to 'net' and queued up for -stable, thanks.
    
DCTCP is meant to be used in environments where the switches/routers do ECN marking, so it is not surprising that it performs badly when used in environments where it was not meant to be used. Has anyone measured the effect of this changed when DCTCP is used in environments where all the switches/routers do ECN marking? My concern is that we could end up hurting performance when DCTCP is used how it was meant to be used in order to protect incorrect uses of DCTCP.