Re: [PATCH RFC tip/core/rcu 1/4] dax/super: Dynamically allocate dax_srcu
From: Paul E. McKenney
Date: Thu Apr 04 2019 - 17:05:08 EST
On Wed, Apr 03, 2019 at 11:31:01AM -0700, Dan Williams wrote:
> On Tue, Apr 2, 2019 at 7:29 AM Paul E. McKenney <paulmck@xxxxxxxxxxxxx> wrote:
> >
> > Having DEFINE_SRCU() or DEFINE_STATIC_SRCU() in a loadable module
> > requires that the size of the reserved region be increased, which is
> > not something we really want to be doing. This commit therefore removes
> > the DEFINE_STATIC_SRCU() from drivers/dax/super.c in favor of defining
> > dax_srcu as a simple srcu_struct, initializing it in dax_core_init(),
> > and cleaning it up in dax_core_exit().
> >
> > Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxx>
>
> Looks good to me.
>
> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
Applied, thank you!
Thanx, Paul