Re: [PATCH 1/3] Revert "staging: vchiq_2835_arm: quit using custom down_interruptible()"
From: Nicolas Saenz Julienne
Date: Fri Apr 05 2019 - 08:22:14 EST
On Fri, 2019-04-05 at 15:02 +0300, Dan Carpenter wrote:
> On Fri, Apr 05, 2019 at 01:34:20PM +0200, Nicolas Saenz Julienne wrote:
> > This reverts commit ff5979ad86368425b7da3a25f4e84650b51ff5fd.
> > ---
>
> Git kind of sets you up for failure with reverts...
>
> Fix the subject, add a commit message and a Signed off by etc. We need
> all the regular stuff. See commit 75ae193626de ("dm: revert
> 8f50e358153d ("dm: limit the max bio size as BIO_MAX_PAGES *
> PAGE_SIZE")") for an example of how to do it nicely.
>
Will do, Thanks!
> regards,
> dan carpenter
>
Attachment:
signature.asc
Description: This is a digitally signed message part