Re: [RFC PATCH] drm/i915: Don't panic on non-empty list of free cachelines

From: Janusz Krzysztofik
Date: Fri Apr 05 2019 - 08:42:24 EST


On Fri, 2019-04-05 at 13:20 +0100, Chris Wilson wrote:
> Quoting Janusz Krzysztofik (2019-04-05 13:13:31)
> > From: Janusz Krzysztofik <janusz.krzysztofik@xxxxxxxxx>
> >
> > If there are active users of a device during driver unbind, the
> > driver
> > now panics on non-empty list of free cachelines.
>
> This panic is there to say that fini is being called with active
> contexts, that it is being called too early. Those requests should be
> cleaned up first, unpinning the contexts and resources, and so
> letting
> the timeline be freed.

OK, I see. But why panic? Maybe a WARN() would be enough.

Thanks,
Janusz

> -Chris
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel