Re: [PATCH] objtool: Don't use -Werror

From: Josh Poimboeuf
Date: Fri Apr 05 2019 - 13:12:12 EST


On Fri, Apr 05, 2019 at 04:35:50PM +0000, David Laight wrote:
> From: Josh Poimboeuf
> > Sent: 05 April 2019 17:21
> ..
> > > FWIW I had to update libelf.so from version 0.153 to 0.165 in
> > > order for the amd64 orc unwinder code in objtool to not generate
> > > corrupt output files.
> > > That is an Ubuntu 13.04 system - nothing like 10 years old.
> >
> > Ah. It would be great if we had a patch to fail the build for old
> > versions of elfutils-libelf as well.
>
> I think the check I added for that specific error got committed.
> Look at the defintion of cmd_objtool in scripts/Makefile.build.
>
> Although I seem to have a local change to the definition of
> cmd_modversions_c.
> It might be that the version of a change I made that got committed
> is missing an extra $ when processing the saved output from 'objdump -h'.
> It used to just pipe into grep - so lost the error result from objdump.

Hm, I don't see that in cmd_objtool, or any commits from you in
scripts/Makefile.build.

--
Josh