Re: [Intel-gfx] [PATCH v3 1/3] drm/gem: don't force writecombine mmap'ing

[Eric Anholt]

Rob Clark <robdclark@xxxxxxxxx> writes:

> From: Rob Clark <robdclark@xxxxxxxxxxxx>
>
> The driver should be in control of this.
>
> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
> ---
> It is possible that this was masking bugs (ie. not setting appropriate
> pgprot) in drivers.  I don't have a particularly good idea for tracking
> those down (since I don't have the hw for most drivers).  Unless someone
> has a better idea, maybe land this and let driver maintainers fix any
> potential fallout in their drivers?
>
> This is necessary for the last patch to fix VGEM brokenness on arm.

This will break at least v3d and panfrost, and it looks like cirrus as
well, since you're now promoting the mapping to cached by default and
drm_gem_shmem_helper now produces cached mappings.  That's all I could
find that would break, but don't trust me on that.

Attachment: signature.asc
Description: PGP signature