Re: [PATCH] powerpc: remove meaningless KBUILD_ARFLAGS addition

[Masahiro Yamada]

On Wed, Jul 17, 2019 at 11:38 PM Segher Boessenkool
<segher@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jul 16, 2019 at 10:15:47PM +1000, Michael Ellerman wrote:
> > Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx> writes:
> > And it's definitely calling ar with no flags, eg:
> >
> >   rm -f init/built-in.a; powerpc-linux-ar rcSTPD init/built-in.a init/main.o init/version.o init/do_mounts.o init/do_mounts_rd.o init/do_mounts_initrd.o init/do_mounts_md.o init/initramfs.o init/init_task.o
>
> This uses thin archives.  Those will work fine.
>
> The failing case was empty files IIRC, stuff created from no inputs.

Actually, empty files are created everywhere.
I do not see any problems whether the target is 32-bit or 64-bit.


Just try allnoconfig, for example.
You can apply the following to debug.


diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index be38198d98b2..9d6b30e50663 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -413,6 +413,7 @@ quiet_cmd_ar_builtin = AR      $@
       cmd_ar_builtin = rm -f $@; $(AR) rcSTP$(KBUILD_ARFLAGS) $@
$(real-prereqs)

 $(builtin-target): $(real-obj-y) FORCE
+       @$(if $(real-prereqs),,echo creating empty archive: $@)
        $(call if_changed,ar_builtin)

 targets += $(builtin-target)

The following are all empty files created from no input.

creating empty archive: usr/built-in.a
creating empty archive: arch/powerpc/crypto/built-in.a
creating empty archive: arch/powerpc/math-emu/built-in.a
  CHK     include/generated/compile.h
creating empty archive: arch/powerpc/net/built-in.a
creating empty archive: arch/powerpc/platforms/built-in.a
creating empty archive: arch/powerpc/sysdev/built-in.a
creating empty archive: certs/built-in.a
creating empty archive: ipc/built-in.a
creating empty archive: block/built-in.a
creating empty archive: drivers/amba/built-in.a
creating empty archive: sound/built-in.a
creating empty archive: drivers/auxdisplay/built-in.a
creating empty archive: crypto/built-in.a
creating empty archive: drivers/block/built-in.a
creating empty archive: net/built-in.a
creating empty archive: drivers/bus/built-in.a
creating empty archive: drivers/cdrom/built-in.a
creating empty archive: drivers/char/ipmi/built-in.a
creating empty archive: arch/powerpc/kernel/trace/built-in.a
creating empty archive: drivers/char/agp/built-in.a
creating empty archive: virt/lib/built-in.a
creating empty archive: drivers/clk/actions/built-in.a
creating empty archive: drivers/clocksource/built-in.a
creating empty archive: drivers/clk/analogbits/built-in.a
creating empty archive: drivers/firewire/built-in.a
creating empty archive: drivers/clk/bcm/built-in.a
creating empty archive: drivers/clk/imx/built-in.a
creating empty archive: drivers/clk/imgtec/built-in.a
creating empty archive: drivers/clk/ingenic/built-in.a
creating empty archive: drivers/clk/mediatek/built-in.a
creating empty archive: drivers/gpu/drm/arm/built-in.a
creating empty archive: drivers/clk/mvebu/built-in.a
creating empty archive: drivers/firmware/broadcom/built-in.a
creating empty archive: drivers/firmware/imx/built-in.a
creating empty archive: drivers/gpu/drm/bridge/synopsys/built-in.a
creating empty archive: drivers/clk/renesas/built-in.a
creating empty archive: drivers/firmware/meson/built-in.a
creating empty archive: drivers/firmware/psci/built-in.a
creating empty archive: drivers/clk/ti/built-in.a
creating empty archive: drivers/gpu/drm/hisilicon/built-in.a
creating empty archive: drivers/firmware/tegra/built-in.a
creating empty archive: drivers/gpu/drm/i2c/built-in.a
creating empty archive: drivers/gpu/drm/omapdrm/displays/built-in.a
creating empty archive: drivers/gpu/drm/omapdrm/dss/built-in.a
creating empty archive: drivers/firmware/xilinx/built-in.a
creating empty archive: drivers/gpu/drm/panel/built-in.a
creating empty archive: drivers/gpu/drm/rcar-du/built-in.a
creating empty archive: drivers/hwtracing/intel_th/built-in.a
creating empty archive: kernel/livepatch/built-in.a
creating empty archive: drivers/gpu/drm/tilcdc/built-in.a
creating empty archive: drivers/base/firmware_loader/builtin/built-in.a
creating empty archive: drivers/base/power/built-in.a
creating empty archive: drivers/gpu/vga/built-in.a
creating empty archive: drivers/base/test/built-in.a
creating empty archive: drivers/i2c/algos/built-in.a
creating empty archive: drivers/i3c/built-in.a
creating empty archive: drivers/i2c/busses/built-in.a
creating empty archive: drivers/idle/built-in.a
creating empty archive: drivers/i2c/muxes/built-in.a
creating empty archive: drivers/iommu/built-in.a
creating empty archive: fs/devpts/built-in.a
creating empty archive: drivers/macintosh/built-in.a
creating empty archive: fs/notify/dnotify/built-in.a
creating empty archive: fs/notify/fanotify/built-in.a
creating empty archive: fs/notify/inotify/built-in.a
creating empty archive: drivers/media/common/b2c2/built-in.a
creating empty archive: drivers/media/common/saa7146/built-in.a
creating empty archive: fs/quota/built-in.a
creating empty archive: drivers/media/firewire/built-in.a
creating empty archive: drivers/media/i2c/built-in.a
creating empty archive: drivers/mfd/built-in.a
creating empty archive: drivers/media/common/siano/built-in.a
creating empty archive: drivers/media/common/v4l2-tpg/built-in.a
creating empty archive: drivers/misc/cardreader/built-in.a
creating empty archive: drivers/media/mmc/siano/built-in.a
creating empty archive: drivers/media/common/videobuf2/built-in.a
creating empty archive: drivers/media/pci/b2c2/built-in.a
creating empty archive: drivers/misc/cb710/built-in.a
creating empty archive: drivers/misc/eeprom/built-in.a
creating empty archive: drivers/media/pci/ddbridge/built-in.a
creating empty archive: drivers/misc/lis3lv02d/built-in.a
creating empty archive: drivers/media/platform/cros-ec-cec/built-in.a
creating empty archive: drivers/media/pci/dm1105/built-in.a
creating empty archive: lib/crypto/built-in.a
creating empty archive: drivers/media/rc/keymaps/built-in.a
creating empty archive: drivers/misc/mic/bus/built-in.a
creating empty archive: drivers/misc/ti-st/built-in.a
creating empty archive: drivers/media/platform/davinci/built-in.a
creating empty archive: drivers/media/pci/intel/ipu3/built-in.a
creating empty archive: drivers/media/platform/meson/built-in.a
creating empty archive: drivers/media/platform/omap/built-in.a
creating empty archive: drivers/media/pci/mantis/built-in.a
creating empty archive: drivers/mmc/built-in.a
creating empty archive: drivers/media/pci/netup_unidvb/built-in.a
creating empty archive: drivers/nfc/built-in.a
creating empty archive: drivers/media/pci/ngene/built-in.a
creating empty archive: drivers/net/dsa/b53/built-in.a
creating empty archive: drivers/media/pci/pluto2/built-in.a
creating empty archive: drivers/media/platform/stm32/built-in.a
creating empty archive: drivers/nvme/host/built-in.a
creating empty archive: drivers/nvme/target/built-in.a
creating empty archive: drivers/media/spi/built-in.a
creating empty archive: drivers/net/dsa/microchip/built-in.a
creating empty archive: drivers/net/dsa/mv88e6xxx/built-in.a
creating empty archive: drivers/media/pci/pt1/built-in.a
creating empty archive: drivers/media/tuners/built-in.a
creating empty archive: drivers/media/pci/pt3/built-in.a
creating empty archive: drivers/media/usb/b2c2/built-in.a
creating empty archive: drivers/net/phy/built-in.a
creating empty archive: drivers/media/usb/dvb-usb/built-in.a
creating empty archive: drivers/media/pci/saa7146/built-in.a
creating empty archive: drivers/net/dsa/sja1105/built-in.a
creating empty archive: drivers/media/usb/s2255/built-in.a
creating empty archive: drivers/media/pci/smipcie/built-in.a
creating empty archive: drivers/media/usb/dvb-usb-v2/built-in.a
creating empty archive: drivers/pci/controller/dwc/built-in.a
creating empty archive: drivers/media/usb/siano/built-in.a
creating empty archive: drivers/media/pci/ttpci/built-in.a
creating empty archive: drivers/pci/switch/built-in.a
creating empty archive: drivers/media/usb/stkwebcam/built-in.a
creating empty archive: drivers/platform/built-in.a
creating empty archive: drivers/power/built-in.a
creating empty archive: drivers/media/usb/ttusb-dec/built-in.a
creating empty archive: drivers/media/usb/zr364xx/built-in.a
creating empty archive: drivers/media/usb/ttusb-budget/built-in.a
creating empty archive: drivers/ptp/built-in.a
creating empty archive: drivers/pwm/built-in.a
creating empty archive: drivers/scsi/built-in.a
creating empty archive: drivers/usb/built-in.a
creating empty archive: drivers/soc/amlogic/built-in.a
creating empty archive: drivers/soc/fsl/built-in.a
creating empty archive: drivers/tty/ipwireless/built-in.a
creating empty archive: drivers/soc/bcm/built-in.a
creating empty archive: drivers/soc/mediatek/built-in.a
creating empty archive: drivers/tty/serial/built-in.a
creating empty archive: drivers/video/backlight/built-in.a
creating empty archive: drivers/tty/vt/built-in.a
creating empty archive: drivers/soc/qcom/built-in.a
creating empty archive: drivers/soc/renesas/built-in.a
creating empty archive: drivers/soc/sunxi/built-in.a
creating empty archive: drivers/soc/ti/built-in.a
creating empty archive: drivers/video/fbdev/core/built-in.a
creating empty archive: drivers/soc/xilinx/built-in.a
creating empty archive: drivers/video/fbdev/omap2/omapfb/displays/built-in.a
creating empty archive: drivers/video/fbdev/omap2/omapfb/dss/built-in.a



BTW, your commit 8995ac8702737147115e1c75879a1a2d75627b9e
dates back to 2008.

At that time, thin archive was not used.


--
Best Regards
Masahiro Yamada