Re: [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc

[Gary R Hook]

On 7/18/19 8:16 AM, Chuhong Yuan wrote:
> Use dma_pool_zalloc instead of using dma_pool_alloc to allocate
> memory and then zeroing it with memset 0.
> This simplifies the code.
> 
> Signed-off-by: Chuhong Yuan <hslester96@xxxxxxxxx>

Acked-by: Gary R Hook <gary.hook@xxxxxxx>

> ---
>   drivers/crypto/ccp/ccp-ops.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index 866b2e05ca77..03797c42b336 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -150,14 +150,13 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa,
>   	if (len <= CCP_DMAPOOL_MAX_SIZE) {
>   		wa->dma_pool = cmd_q->dma_pool;
>   
> -		wa->address = dma_pool_alloc(wa->dma_pool, GFP_KERNEL,
> +		wa->address = dma_pool_zalloc(wa->dma_pool, GFP_KERNEL,
>   					     &wa->dma.address);
>   		if (!wa->address)
>   			return -ENOMEM;
>   
>   		wa->dma.length = CCP_DMAPOOL_MAX_SIZE;
>   
> -		memset(wa->address, 0, CCP_DMAPOOL_MAX_SIZE);
>   	} else {
>   		wa->address = kzalloc(len, GFP_KERNEL);
>   		if (!wa->address)
>