Re: [v2 PATCH] padata: Replace delayed timer with immediate workqueue in padata_reorder
From: Herbert Xu
Date: Fri Jul 19 2019 - 10:56:08 EST
On Fri, Jul 19, 2019 at 10:37:21AM -0400, Daniel Jordan wrote:
>
> If I'm not missing anything, still looks like get_cpu() and reorder_via_wq no
> longer have an effect with this patch and can be removed.
You're right that they're not needed. But we shouldn't mix clean-ups
with substantial changes (in case we break something this would make
bisection less efficient). So feel free to send a patch on top of
this one to remove them.
Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt