RE: [PATCH v10 0/6] Introduced new Cadence USBSS DRD Driver.

[Pawel Laszczak]

Hi, 

>
>> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>
>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
>> Host Only (XHCI)configurations.
>
>I see you are using debugfs to select between DRD, peripheral-onlyh and XHCI...
>
>Is that good idea?

Yes driver allows selecting dr_mode by debugfs. Controller also support such functionality 
so I don't understand why would it not be a good idea. 

I personally use this for testing but it can be used to limit controller functionality without 
recompiling kernel. 

>This is at least 3rd driver needing that capability, and debugfs does not
>sound like a good match.
>

Pawell