Re: [PATCH 1/2] [RESEND] dmaengine: omap-dma: make omap_dma_filter_fn private

[Arnd Bergmann]

On Mon, Jul 22, 2019 at 4:36 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
> On 22-07-19, 16:22, Arnd Bergmann wrote:
> > On Mon, Jul 22, 2019 at 4:13 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
> > >
> > > On 22-07-19, 10:16, Arnd Bergmann wrote:
> > > > With the audio driver no longer referring to this function, it
> > > > can be made private to the dmaengine driver itself, and the
> > > > header file removed.
> > > >
> > > > Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> > > > Link: https://lore.kernel.org/lkml/20190307151646.1016966-1-arnd@xxxxxxxx/
> > >
> > > This seems to point to older rev, my script updated it to latest one.
> >
> > That was intentional, to see the replies to the last time it got
> > posted. I'm not sure if that's the best way to do it, would you
> > rather not have that included?
>
> That's a valid point, but should we add both the links or just relevant
> one, common sense says former, scripting tends to add so keep both...?
>
> I am thinking of not changing the one submitted and let my
> script append. Is that fine?

I think adding both is best then.

       Arnd