Re: [PATCH v2] iommu: add support for drivers that manage iommu explicitly
From: Rob Clark
Date: Mon Jul 22 2019 - 12:24:02 EST
On Mon, Jul 22, 2019 at 8:48 AM Joerg Roedel <joro@xxxxxxxxxx> wrote:
>
> On Mon, Jul 22, 2019 at 08:41:34AM -0700, Rob Clark wrote:
> > It is set by the driver:
> >
> > https://patchwork.freedesktop.org/patch/315291/
> >
> > (This doesn't really belong in devicetree, since it isn't a
> > description of the hardware, so the driver is really the only place to
> > set this.. which is fine because it is about a detail of how the
> > driver works.)
>
> It is more a detail about how the firmware works. IIUC the problem is
> that the firmware initializes the context mappings for the GPU and the
> OS doesn't know anything about that and just overwrites them, causing
> the firmware GPU driver to fail badly.
>
> So I think it is the task of the firmware to tell the OS not to touch
> the devices mappings until the OS device driver takes over. On x86 there
> is something similar with the RMRR/unity-map tables from the firmware.
>
Bjorn had a patchset[1] to inherit the config from firmware/bootloader
when arm-smmu is probed which handles that part of the problem. My
patch is intended to be used on top of his patchset. This seems to me
like the best solution, if we don't have control over the firmware.
BR,
-R
[1] https://www.spinics.net/lists/arm-kernel/msg732246.html