Re: [PATCH][next] clk: Si5341/Si5340: remove redundant assignment to n_den

[Christophe JAILLET]

Le 22/07/2019 Ã 23:24, Stephen Boyd a ÃcritÂ:
> Please Cc authors of drivers so they can ack/review.
>
> Adding Mike to take a look.
>
> Quoting Colin King (2019-07-01 09:50:20)
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > The variable n_den is initialized however that value is never read
> > as n_den is re-assigned a little later in the two paths of a
> > following if-statement.  Remove the redundant assignment.
> >
> > Addresses-Coverity: ("Unused value")
> > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> > ---
> >   drivers/clk/clk-si5341.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c
> > index 72424eb7e5f8..6e780c2a9e6b 100644
> > --- a/drivers/clk/clk-si5341.c
> > +++ b/drivers/clk/clk-si5341.c
> > @@ -547,7 +547,6 @@ static int si5341_synth_clk_set_rate(struct clk_hw *hw, unsigned long rate,
> >          bool is_integer;
> >   
> >          n_num = synth->data->freq_vco;
> > -       n_den = rate;
> >   
> >          /* see if there's an integer solution */
> >          r = do_div(n_num, rate);
Hi,

I got the same advise from some else no later than yesterday (i.e. email 
the author...)
Maybe 'get_maintainer.pl' could be improved to search for it and propose 
the mail automatically?

just my 2c.


CJ