Re: [PATCH 1/4] block: elevator.c: Remove now unused elevator= argument

From: Bob Liu
Date: Mon Jul 22 2019 - 19:51:51 EST


On 7/14/19 1:34 PM, Marcos Paulo de Souza wrote:
> Since the inclusion of blk-mq, elevator argument was not being
> considered anymore, and it's utility died long with the legacy IO path,
> now removed too.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@xxxxxxxxx>
> ---
> block/elevator.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/block/elevator.c b/block/elevator.c
> index 2f17d66d0e61..f56d9c7d5cbc 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -135,20 +135,6 @@ static struct elevator_type *elevator_get(struct request_queue *q,
> return e;
> }
>
> -static char chosen_elevator[ELV_NAME_MAX];
> -
> -static int __init elevator_setup(char *str)
> -{
> - /*
> - * Be backwards-compatible with previous kernels, so users
> - * won't get the wrong elevator.
> - */
> - strncpy(chosen_elevator, str, sizeof(chosen_elevator) - 1);
> - return 1;
> -}
> -
> -__setup("elevator=", elevator_setup);
> -
> static struct kobj_type elv_ktype;
>
> struct elevator_queue *elevator_alloc(struct request_queue *q,
>

Reviewed-by: Bob Liu <bob.liu@xxxxxxxxxx>