Re: [PATCH -next v5] mm/hotplug: silence a lockdep splat with printk()

[David Hildenbrand]

> diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h
> index 148e65a9c606..da043ae86488 100644
> --- a/include/linux/page-isolation.h
> +++ b/include/linux/page-isolation.h
> @@ -33,8 +33,8 @@ static inline bool is_migrate_isolate(int migratetype)
>  #define MEMORY_OFFLINE	0x1
>  #define REPORT_FAILURE	0x2
>  
> -bool has_unmovable_pages(struct zone *zone, struct page *page, int migratetype,
> -			 int flags);
> +struct page *has_unmovable_pages(struct zone *zone, struct page *page, int
> +				 migratetype, int flags);

the "int" should go onto the next line as well
[...]

apart from that looks good to me. I hope we won't have a whac-a-mole
with printk() (including WARN_ON() etc?) under the zone lock. This all
screams for a better fix.

As this patch is now fairly small and seems to do the trick for now

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

-- 
Thanks,

David / dhildenb