Re: [PATCH] m68k: q40: Add space around '='

[Geert Uytterhoeven]

Hi Hanyu,

On Thu, Jul 13, 2023 at 8:40 AM <hanyu001@xxxxxxxxxx> wrote:
> This patch fixes the checkpatch.pl error:
>
> ./arch/m68k/q40/q40ints.c:135: ERROR: spaces required around that '='
> (ctx:VxV)
> ./arch/m68k/q40/q40ints.c:137: ERROR: spaces required around that '='
> (ctx:VxV)
> ./arch/m68k/q40/q40ints.c:138: ERROR: spaces required around that '='
> (ctx:VxV)
>
> Signed-off-by: maqimei <2433033762@xxxxxx>

Thanks for your patch!

But obviously you forgot to run scripts/checkpatch.pl on your own patch:

    ERROR: patch seems to be corrupt (line wrapped?)
    #81: FILE: arch/m68k/q40/q40ints.c:131:
    *dev_id)

    ERROR: Missing Signed-off-by: line by nominal patch author
'hanyu001@xxxxxxxxxx'

> Fwd: [PATCH] m68k: q40: Add space around '='

Please do not forward patches, as this breaks the tooling.
The proper way to handle this is to add your own Signed-off-by tag,
and submit it yourself, cfr.
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L434

> index 127d7ec..bede94a 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -132,10 +132,10 @@ static irqreturn_t q40_timer_int(int irq, void
> *dev_id)
>   {
>       ql_ticks = ql_ticks ? 0 : 1;
>       if (sound_ticks) {
> -        unsigned char sval=(sound_ticks & 1) ? 128-SVOL : 128+SVOL;
> +        unsigned char sval = (sound_ticks & 1) ? 128-SVOL : 128+SVOL;
>           sound_ticks--;
> -        *DAC_LEFT=sval;
> -        *DAC_RIGHT=sval;
> +        *DAC_LEFT = sval;
> +        *DAC_RIGHT = sval;
>       }
>
>       if (!ql_ticks) {

This patch is whitespace-damaged and fails to apply.

Please test your patches by running scripts/checkpatch.pl, emailing
them to yourself, and trying to apply them.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds