Re: [PATCH net-next] Bluetooth: Remove unused declaration amp_read_loc_info()

[YueHaibing]

On 2023/7/26 23:11, Paul Menzel wrote:
> Dear YueHaibing,
> 
> 
> Thank you very much for your patch.
> 
> Am 26.07.23 um 16:28 schrieb YueHaibing:
>> This is never used, so remove it.
>>
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> 
> Should your name be spelled with a space: Yue Haibing?
> 
>     $ git config --global user.name "Yue Haibing"
>     $ git commit --amend --author="Yue Haibing <yuehaibing@xxxxxxxxxx>"

Thanks，will fix this.
>> ---
>>   net/bluetooth/amp.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
>> index 832764dfbfb3..97c87abd129f 100644
>> --- a/net/bluetooth/amp.h
>> +++ b/net/bluetooth/amp.h
>> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>>     int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>>   -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
> 
> Was it never implemented, or just forgotten to be removed?

This is introduce in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
and never implemented. I will update this to commit message.

> 
>>   void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>>   void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>>   void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
> 
> 
> Kind regards,
> 
> Paul
> 
> .