Re: [PATCH] x86/paravirt: Fix tlb_remove_table function callback prototype warning

[Juergen Gross]

On 27.07.23 01:11, Kees Cook wrote:
> Under W=1, this warning is visible in Clang 16 and newer:
>
> arch/x86/kernel/paravirt.c:337:4: warning: cast from 'void (*)(struct mmu_gather *, struct page *)' to 'void (*)(struct mmu_gather *, void *)' converts to incompatible function type [-Wcast-function-type-strict]
>                             (void (*)(struct mmu_gather *, void *))tlb_remove_page,
>                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Add a direct wrapper instead, which will make this warning (and
> potential KCFI failures) go away.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307260332.pJntWR6o-lkp@xxxxxxxxx/
> Cc: Juergen Gross <jgross@xxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
> Cc: Ajay Kaher <akaher@xxxxxxxxxx>
> Cc: Alexey Makhalov <amakhalov@xxxxxxxxxx>
> Cc: VMware PV-Drivers Reviewers <pv-drivers@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature