Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations
From: Daniel Wagner
Date: Thu Jul 27 2023 - 03:19:52 EST
- Next message: Greg Kroah-Hartman: "Linux 5.4.251"
- Previous message: Krzysztof Kozlowski: "Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support"
- In reply to: Bart Van Assche: "Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations"
- Next in thread: Bart Van Assche: "Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Wed, Jul 26, 2023 at 07:54:24AM -0700, Bart Van Assche wrote:
> On 7/26/23 05:46, Daniel Wagner wrote:
> > Group all variable declarations together at the beginning of the
> > function.
>
> An explanation of why this change has been proposed is missing from the
> patch description.
Sure, I'll add one. The coding style to declare all local variables at the
beginning of the function.
> I think the current style, with variable declarations occurring just before
> the first use of a variable, is on purpose. I like that style.
The majority of functions declare variables at the beginning of the functions.
As you can see these are only a handful of declerations which do not adhere to
the coding style.
- Next message: Greg Kroah-Hartman: "Linux 5.4.251"
- Previous message: Krzysztof Kozlowski: "Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support"
- In reply to: Bart Van Assche: "Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations"
- Next in thread: Bart Van Assche: "Re: [PATCH blktests v1 01/11] nvme/{003,004,005,013,046,049}: Group all variables declarations"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]