Re: [PATCH] nvme: Don't fail to resume if NSIDs change

[Limonciello, Mario]

On 7/31/2023 3:10 PM, Christoph Hellwig wrote:
> On Mon, Jul 31, 2023 at 03:09:08PM -0500, Limonciello, Mario wrote:
> > So is it reasonable to just add a check for
> >
> > ctrl->oacs & NVME_CTRL_OACS_NS_MNGT_SUPP
> >
> > In the same error handling path as this patch?
>
> No.  There are tons of NVMe devices that only support creating and
> deleting namespace out of band, especially in virtualized and cloud
> setups.

Even if it's only the error handling path only that it's checked?

If you don't want more changes or heuristics on the error handling path 
for this case, I think the best solution is probably to pick up

https://lore.kernel.org/all/20221116171727.4083-1-git@xxxxxxxxxxxxxxxxxx/t/

instead then and hopefully we don't end up with more disks like this.