Re: [PATCH v3 1/1] nvme: multipath: Implemented new iopolicy "queue-depth"

[Sagi Grimberg]

On 21/05/2024 13:15, Sagi Grimberg wrote:
> On 21/05/2024 13:11, Sagi Grimberg wrote:
> > > > Don't think this matters because cancellation only happens when we
> > > > teardown the controller anyways...
> > > I think in case if we reset the nvme controller then we don't teardown
> > > controller, isn't it? In this case we cancel all pending requests, and
> > > later restart the controller.
> >
> > Exactly, nvme_mpath_init_ctrl resets the counter.
>
> Except you're right, the counter reset needs to move to 
> nvme_mpath_init_identify()
> or some place that is called on every controller reset.

This however raises the question of how much failover/reset tests this 
patch has seen...