Re: [RFC PATCH 1/5] cfq-iosched: adapt slice to number ofprocesses doing I/O

[Jens Axboe]

On Mon, Oct 19 2009, Corrado Zoccolo wrote:
> When the number of processes performing I/O concurrently increases,
> a fixed time slice per process will cause large latencies.
> 
> This patch, if low_latency mode is enabled,  will scale the time slice
> assigned to each process according to a 300ms target latency.
> 
> In order to keep fairness among processes:
> * The number of active processes is computed using a special form of
> running average, that quickly follows sudden increases (to keep latency low),
> and decrease slowly (to have fairness in spite of rapid decreases of this
> value).
> 
> To safeguard sequential bandwidth, we impose a minimum time slice
> (computed using 2*cfq_slice_idle as base, adjusted according to priority
> and async-ness).

Generally, this looks good. Just one minor style nit:

> +static inline unsigned
> +cfq_get_avg_queues(struct cfq_data *cfqd, bool rt) {
> +	unsigned min_q, max_q;
> +	unsigned mult  = cfq_hist_divisor - 1;
> +	unsigned round = cfq_hist_divisor / 2;
> +	unsigned busy  = rt ? cfqd->busy_rt_queues :
> +		(cfqd->busy_queues - cfqd->busy_rt_queues);
> +	min_q = min(cfqd->busy_queues_avg[rt], busy);
> +	max_q = max(cfqd->busy_queues_avg[rt], busy);
> +	cfqd->busy_queues_avg[rt] = (mult * max_q + min_q + round) /
> +		cfq_hist_divisor;
> +	return cfqd->busy_queues_avg[rt];
> +}

A lot of your code suffers from the specific problem of being largely
unreadable. To me, as the maintainer of that code, that is a maintenance
issue. I already asked you to get rid of the ?: constructs for earlier
patches, this series even takes it to the extreme of doing nested ?:
clauses. Don't do it! It's unreadable.

> @@ -2152,10 +2186,9 @@ static void cfq_insert_request(struct request_queue *q, struct request *rq)
>  	cfq_log_cfqq(cfqd, cfqq, "insert_request");
>  	cfq_init_prio_data(cfqq, RQ_CIC(rq)->ioc);
>  
> -	cfq_add_rq_rb(rq);
> -
>  	rq_set_fifo_time(rq, jiffies + cfqd->cfq_fifo_expire[rq_is_sync(rq)]);
>  	list_add_tail(&rq->queuelist, &cfqq->fifo);
> +	cfq_add_rq_rb(rq);
>  
>  	cfq_rq_enqueued(cfqd, cfqq, rq);

If the fifo vs service tree ordering is now important, you should
comment on why.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/