Re: [RFC PATCH 1/5] cfq-iosched: adapt slice to number of processes doing I/O

[Corrado Zoccolo]

On Tue, Oct 20, 2009 at 2:54 AM, Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
> On Mon, Oct 19 2009, Corrado Zoccolo wrote:
>> When the number of processes performing I/O concurrently increases,
>> a fixed time slice per process will cause large latencies.
>>
>> This patch, if low_latency mode is enabled, Âwill scale the time slice
>> assigned to each process according to a 300ms target latency.
>>
>> In order to keep fairness among processes:
>> * The number of active processes is computed using a special form of
>> running average, that quickly follows sudden increases (to keep latency low),
>> and decrease slowly (to have fairness in spite of rapid decreases of this
>> value).
>>
>> To safeguard sequential bandwidth, we impose a minimum time slice
>> (computed using 2*cfq_slice_idle as base, adjusted according to priority
>> and async-ness).
>
> Generally, this looks good. Just one minor style nit:
>
>> +static inline unsigned
>> +cfq_get_avg_queues(struct cfq_data *cfqd, bool rt) {
>> + Â Â unsigned min_q, max_q;
>> + Â Â unsigned mult Â= cfq_hist_divisor - 1;
>> + Â Â unsigned round = cfq_hist_divisor / 2;
>> + Â Â unsigned busy Â= rt ? cfqd->busy_rt_queues :
>> + Â Â Â Â Â Â (cfqd->busy_queues - cfqd->busy_rt_queues);
>> + Â Â min_q = min(cfqd->busy_queues_avg[rt], busy);
>> + Â Â max_q = max(cfqd->busy_queues_avg[rt], busy);
>> + Â Â cfqd->busy_queues_avg[rt] = (mult * max_q + min_q + round) /
>> + Â Â Â Â Â Â cfq_hist_divisor;
>> + Â Â return cfqd->busy_queues_avg[rt];
>> +}
>
> A lot of your code suffers from the specific problem of being largely
> unreadable. To me, as the maintainer of that code, that is a maintenance
> issue. I already asked you to get rid of the ?: constructs for earlier
> patches, this series even takes it to the extreme of doing nested ?:
> clauses. Don't do it! It's unreadable.

Ok. I'll resubmit a revised version of the patches that address this
stile issue, as well as your concern with too large functions and
lacking comments.
I didn't realize that you hated ?: so much :).
To me, it seems a good way to achieve a different readability goal,
i.e. define the value of a variable in a single place, instead of
scattering it around on multiple lines.
>
>> @@ -2152,10 +2186,9 @@ static void cfq_insert_request(struct request_queue *q, struct request *rq)
>> Â Â Â cfq_log_cfqq(cfqd, cfqq, "insert_request");
>> Â Â Â cfq_init_prio_data(cfqq, RQ_CIC(rq)->ioc);
>>
>> - Â Â cfq_add_rq_rb(rq);
>> -
>> Â Â Â rq_set_fifo_time(rq, jiffies + cfqd->cfq_fifo_expire[rq_is_sync(rq)]);
>> Â Â Â list_add_tail(&rq->queuelist, &cfqq->fifo);
>> + Â Â cfq_add_rq_rb(rq);
>>
>> Â Â Â cfq_rq_enqueued(cfqd, cfqq, rq);
>
> If the fifo vs service tree ordering is now important, you should
> comment on why.
It's not important for the patches per se, but I found odd (and it
caused me some headache while debugging) that in cfq_add_rq_rb the
fifo was still empty.
In the new form, the rq will be complete when added, while in the
previous, it still had some empty fields.

Corrado
>
> --
> Jens Axboe
>
>



-- 
__________________________________________________________________________

dott. Corrado Zoccolo                          mailto:czoccolo@xxxxxxxxx
PhD - Department of Computer Science - University of Pisa, Italy
--------------------------------------------------------------------------
The self-confidence of a warrior is not the self-confidence of the average
man. The average man seeks certainty in the eyes of the onlooker and calls
that self-confidence. The warrior seeks impeccability in his own eyes and
calls that humbleness.
                               Tales of Power - C. Castaneda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/