Re: spitz backlight: fix brightness limiting
From: Pavel Machek
Date: Fri Oct 23 2009 - 01:21:16 EST
On Thu 2009-10-22 23:43:19, Richard Purdie wrote:
> On Thu, 2009-10-22 at 04:20 +0800, Eric Miao wrote:
> > It's a little bit weird it's called 'limit_mask' when I first converted it
> > to a spi driver. There must be some reasons, Richard, you've got
> > any ideas?
>
> Its a historical artifact that once worked through some bitfield magic
> but probably stopped working when we increased the range of values the
> backlight could accept and we didn't notice the limiting problem.
>
> I'll happily take a patch to fix that.
Patch is available in the parent post. For now, I just fix it so that
it does not turn backlight off when it should not. I'll submit
limit_mask -> limit as separate patch, ok?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/