Re: [PATCH 4/4 v2] ASoC: TWL4030: Driver registration via twl4030_codec MFD

From: Peter Ujfalusi
Date: Fri Oct 23 2009 - 01:28:25 EST


On Thursday 22 October 2009 19:56:44 ext Mark Brown wrote:
> On Thu, Oct 22, 2009 at 01:26:48PM +0300, Peter Ujfalusi wrote:
> > Change the way how the twl4030 soc codec driver is
> > loaded/probed.
> > Use the device probing via tlw4030_codec MFD device.
>
> I'm OK with the series but:
> > @@ -147,6 +147,7 @@ config SND_SOC_TLV320DAC33
> > tristate
> >
> > config SND_SOC_TWL4030
> > + select TWL4030_CODEC
> > tristate
>
> due to Kconfig ignoring dependencies all the individual machine drivers
> are going to need to select this, and SND_SOC_ALL_CODECS will need to
> select it if the MFD core is enabled. I should be able to fix this up
> myself so no need to repost for that alone.

Hmm, what do you mean by that?
I have checked it, and selecting the machine driver will enables the MFD_CORE
and TWL4030_CODEC in .config, also disabling the machine driver will also
disable the MFD_CORE and the TWL4030_CODEC.

Can you go into details?

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/