Re: [PATCH] perf timechart: Use pr_debug to report unknown headertypes

[Frederic Weisbecker]

On Fri, Oct 23, 2009 at 11:37:59AM -0700, Arjan van de Ven wrote:
> Arnaldo Carvalho de Melo wrote:
>> Em Fri, Oct 23, 2009 at 10:55:39AM -0700, Arjan van de Ven escreveu:
>>> Arnaldo Carvalho de Melo wrote:
>>>> It was using eprintf that checked if verbose was !zero, when I converted
>>>> to pr_*() I made the mistake of changing it to pr_warning which caused
>>>> 'perf timechart' output to be way too verbose.
>>>>
>>> nack...
>>>
>>> if you EVER hit one of these you have a very very serious problem.
>>> hiding that is never the right thing to do. I should make this a fatal
>>> event instead.
>>
>> OK, so I actually fixed a bug as those messages weren't being noticed if
>> -v wasn't used! :-)
>>
>> Please take a look at latest tip to see all those messages.
>>
>> - Arnaldo
>
> I'm pretty sure latest -tip broke timechart; Frederic tends to have a habit of doing so occasionally :)
>


Yeah but I usually fix what I break. Because I need the things to be working
again if I want to happily continue breaking them :o)

/me wonders if he hasn't played too much legos when he was a child. That
may have provided him a strange vision of the world.

That said I've tested timechart few days ago and it worked very well. (That
was also the first time it worked for me).

So I guess it should be fine.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/