Re: [PATCH 2/2] memcg: move memcg_update_cache_size to slab_common.c

[Vladimir Davydov]

On Mon, Sep 22, 2014 at 04:11:37PM -0400, Johannes Weiner wrote:
> On Thu, Sep 18, 2014 at 07:50:20PM +0400, Vladimir Davydov wrote:
> > @@ -646,11 +646,13 @@ int memcg_limited_groups_array_size;
> >  struct static_key memcg_kmem_enabled_key;
> >  EXPORT_SYMBOL(memcg_kmem_enabled_key);
> >  
> > +static void memcg_free_cache_id(int id);
> 
> Any chance you could re-order this code to avoid the forward decl?

I'm going to move the call to memcg_free_cache_id() from the css free
path to css offline. Actually, this is what "[PATCH -mm 08/14] memcg:
release memcg_cache_id on css offline", which is a part of my "Per memcg
slab shrinkers" patch set, does. The css offline path is defined below
css_alloc/free_cache_id, so the forward declaration will be removed
then.

Thanks,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/